Catch exceptions from service handler and return internal error #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgreni
changed the title
bgreni
force-pushed
the
catch-handler-exceptions
branch
from
adcbaaf to
2181258
Compare
Collaborator
Author
|
@saviorand FYI this is a pretty harmless change so I'm going to go ahead and merge it. Just prevents the server from crashing if something goes wrong in the handler and allows users to create a 500 response by just raising an Error which I think is the intuitive behaviour. |
Collaborator
|
Nice! Also prints in integration tests are helpful. The only feedback I have is I found a typo in IntegerationTestService (should be IntegrationTestService) , also I think it's good to call INTERNAL_ERROR alias just INTERNAL_SERVER_ERROR because these aliases correspond to HTTP codes anyway. I can fix those two separately though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
500error